Add TodoMVC with indexedDB storage#531
Open
issackjohn wants to merge 33 commits intoWebKit:mainfrom
Open
Conversation
✅ Deploy Preview for webkit-speedometer-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
Opening a replacement PR to take over: The original PR author is no longer available. I copied the current branch state and will address existing review feedback here. Please see the old PR for historical context: #523 . If anything is missing, let me know and I’ll add it here. |
added 24 commits
February 5, 2026 16:01
…he indexedDB version
* Fix typo in finishedAdditions variable name in BaseStorageManager * Commit transaction after sorting items in getTodos method * Simplify toggleTodo method by using update for completion status * Fix sorting order comment in getTodos method for clarity
issackjohn
force-pushed
the
issackjohn-WCIndexeddb
branch
from
8383f2e to
d137671
Compare
Contributor
Author
|
@abhishek-shanthkumar I am unable to add you as a reviewer so could you please join as a reviewer? Thanks! |
Contributor
Author
|
- test-invoker: Propagate results in AsyncRAFTestInvoker so BenchmarkSuite.runAndRecord receives timing data instead of undefined. - test-runner: Add null-page fallback in measureAsync so remote workloads that pass null for frame/page can still force layout.
Remove local forks of helpers.mjs, params.mjs, test-invoker.mjs, and test-runner.mjs. The build now copies these directly from the shared node_modules/speedometer-utils package. Only benchmark.mjs remains forked (has ignoreResult support and AsyncTestRunner selection).
camillobruni
approved these changes
May 5, 2026
| const numberOfItemsPerIteration = 10; | ||
| const numberOfIterations = 10; | ||
| function iterationFinishedListener() { | ||
| iterationFinishedListener.promiseResolve(); |
Contributor
There was a problem hiding this comment.
nit: I'd prefer a local variable instead of a setting state on a function, this is a bit unexpected maybe.
| if (j < 9) { | ||
| const previousPageButton = document.querySelector("todo-app").shadowRoot.querySelector("todo-bottombar").shadowRoot.querySelector(".previous-page-button"); | ||
| previousPageButton.click(); | ||
| await iterationFinishedPromise; |
Contributor
There was a problem hiding this comment.
so far I don't see any real interactions inbetween this phase.. .but we might have to tweak this in the future if we want t compare performacne reliably. (delete and he read migh have to sync the DB I guess)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Results for the hosted prototype as of 12/12/2025